api rest send array json - json

Question

I am trying to send an array of a record to my client by using an API rest with Laravel.
This is my code
public function index ($id) {
$gards = DB::table('gards')
->whereRaw('date_from < Now() AND date_to > Now() AND (gard_day = 1 OR gard_night = 1)')
->get();
foreach($gards as $gard) {
$id_pharma = $gard->pharmacy_id;
$pharmacy = DB::table('pharmacies')->whereRaw("id = {$id_pharma} AND city_id = {$id}")->get();
return response()->json($pharmacy, 200);
}
}
But it sends only the first record.
Any help will be appreciated.

Answer 1

With your approach, you are falling into the n+1 queries dillema (read more on Google), but basically, you are doing a query for each of the lines in the 'gards' table. This is super inefficient. There may be a better way to acheive this with relations, but the following solution only executes 2 queries and you get your result.
public function index ($id) {
$ids = DB::table('gards')
->whereRaw('date_from < Now() AND date_to > Now() AND (gard_day = 1 OR gard_night = 1)')
->pluck('pharmacy_id');
//The pluck function gets all the pharmacy_id and it assigns them to the $ids variable.
$pharmacies = DB::table('pharmacies')
->whereIn('id', $ids)
->where('city_id', $id)
->get();
return response()->json($pharmacies);
}