How to optimize multiple sub-queries from multiple tables? - mysql

Question

I have two Table such as tnx_lc_invoice and tnx_lc_payment. I want to generate report from this two tables.
Table schema like below images
tnx_lc_payment
tnx_lc_invoice
I want to generate output like below images
output
I am trying below query and its generate similar output. but i want to optimize this query or any alternative solution for faster result.
SELECT
a.lc_no,
a.invoiceValue,
b.paymentValue,
(
a.invoiceValue - b.paymentValue
) AS shortPaymentValue
FROM
(
SELECT
lc_no,
sum(invoice_value) AS invoiceValue
FROM
tnx_lc_invoice
GROUP BY
lc_no
) a
INNER JOIN (
SELECT
lc_no,
sum(payment_value) AS paymentValue
FROM
tnx_lc_payment
GROUP BY
lc_no
) b ON a.lc_no = b.lc_no
If any other alternative easy solution please let me know.Thanks in advance.

Answer 1

Instead of using subqueries create an inner direct between them
SELECT
a.lc_no,
sum(a.invoice_value) AS invoiceValue,
sum(b.payment_value) AS payment_value,
(sum(a.invoice_value) - sum(b.paymentValue)) AS shortPaymentValue
FROM tnx_lc_invoice a
INNER JOIN tnx_lc_payment b
ON a.lc_no = b.lc_no
GROUP BY
a.lc_no
The query was not correct because it multiply the rows if both invoice and payments are duplicated on the same lc_no.
So it is necessary to add at least one group by in an inner query.
SELECT
a.lc_no,
sum(a.invoice_value) AS invoiceValue,
sum(b.payment_value) AS payment_value,
sum(a.invoice_value) - sum(b.payment_Value) AS shortPaymentValue
FROM (select lc_no, sum(invoice_value) as invoice_value
from tnx_lc_invoice group by lc_no) a
INNER JOIN tnx_lc_payment b
ON a.lc_no = b.lc_no
GROUP BY
a.lc_no