Is this a t sql stored proceedure - mysql

Question

I want to execute this from within Excel (SQL query window) where I would normally only execute the select statement. Should I make it into a stored proceedure and then execute tat from within Excel?
BEGIN TRY
drop table GlobalShop.dbo.v_order_hist_dtl_Quote
END TRY
BEGIN CATCH
END CATCH
BEGIN TRY
drop table GlobalShop.dbo.v_order_lines_Quote
END TRY
BEGIN CATCH
END CATCH
select * into GlobalShop.dbo.v_order_hist_dtl_Quote
from GlobalShop.dbo.v_order_hist_dtl where isnull(USER_3,'') <> ''
select * into GlobalShop.dbo.v_order_lines_Quote
from GlobalShop.dbo.v_order_lines where isnull(USER_3,'') <> ''
/* Quotes with Orders 1.0 */
select
QT.QuoteNum,
QT.custID,
QT.QCustNum,
QT.QCustName,
QT.QDate,
COUNT(OL.order_no) as #_Open_Orders,
COUNT(OH.order_no) as #_Closed_Orders
from
"Track Quotes".dbo.TrackQuotesHist as QT
left outer join GlobalShop.dbo.v_order_hist_dtl_quote as OH
on QT.QuoteNum = OH.USER_3
left outer join GlobalShop.dbo.v_order_lines_quote as OL
on QT.QuoteNum = OL.USER_3
where
QT.QDate between '03/01/2015' and '03/06/2015'
Group By
QT.QuoteNum,
QT.custID,
QT.QCustNum,
QT.QCustName,
QT.QDate

Answer 1

If you only want to run the select statements most of the time I would make the drops into one stored procedure (if you ever want to do it) and then the select into another.

Answer 2

In my world I assume an object that starts with v_ is a view but you seem to treat it as a table and if it is change it to something like this:
create proc dbo.procfiles
as
BEGIN
if object_id('GlobalShop.dbo.v_order_hist_dtl_Quote','U') is not null
drop table GlobalShop.dbo.v_order_hist_dtl_Quote
if object_id('GlobalShop.dbo.v_order_lines_Quote','U') is not null
drop table GlobalShop.dbo.v_order_lines_Quote
select * into GlobalShop.dbo.v_order_hist_dtl_Quote
from GlobalShop.dbo.v_order_hist_dtl where user_3 is not null
select * into GlobalShop.dbo.v_order_lines_Quote
from GlobalShop.dbo.v_order_lines where user_3 is not null
/* Quotes with Orders 1.0 */
select
QT.QuoteNum,
QT.custID,
QT.QCustNum,
QT.QCustName,
QT.QDate,
COUNT(OL.order_no) as #_Open_Orders,
COUNT(OH.order_no) as #_Closed_Orders
from
"Track Quotes".dbo.TrackQuotesHist as QT
left outer join GlobalShop.dbo.v_order_hist_dtl_quote as OH
on QT.QuoteNum = OH.USER_3
left outer join GlobalShop.dbo.v_order_lines_quote as OL
on QT.QuoteNum = OL.USER_3
where
QT.QDate between '03/01/2015' and '03/06/2015'
Group By
QT.QuoteNum,
QT.custID,
QT.QCustNum,
QT.QCustName,
QT.QDate
begin catch
select
ERROR_NUMBER(),
ERROR_SEVERITY(),
ERROR_STATE(),
ERROR_PROCEDURE(),
ERROR_LINE(),
ERROR_MESSAGE()
end catch
end

Answer 3

Unless you have a very compelling reason to update those tables every time this query is run, I would avoid them. Just use equivalent query without the use of the tables:
select
QT.QuoteNum,
QT.custID,
QT.QCustNum,
QT.QCustName,
QT.QDate,
COUNT(OL.order_no) as #_Open_Orders,
COUNT(OH.order_no) as #_Closed_Orders
from "Track Quotes".dbo.TrackQuotesHist as QT
left outer join GlGlobalShop.dbo.v_order_hist_dtl OH
on QT.QuoteNum = OH.USER_3
and isnull(QT.QuoteNum,'')<>''
left outer join GlobalShop.dbo.v_order_lines OL
on QT.QuoteNum = OL.USER_3
and isnull(QT.QuoteNum,'')<>''
where QT.QDate between '03/01/2015' and '03/06/2015'
Group By
QT.QuoteNum,
QT.custID,
QT.QCustNum,
QT.QCustName,
QT.QDate