Eloquent simplify / combine query - mysql

Question

I'm trying to simplify the following query. I have a meter and a relation (+ or -) and I would like to sum date-ranges based on the meter criteria. The positive meters should be summed up and the negative ones subtracted from the sum. As showed below, I split the meter array into two arrays ($meter_plus, $meter_minus) with ids only, both for sum values, but $meter_minus should be subtracted.
// Edit: Fetching meters
$begin = new \DateTime($from);
$end = new \DateTime($to);
$end = $end->modify('+1 day');
// find points and meters by group
$grouping = App\Grouping::with('points.meters')->find($group_id);
$meter_plus = [];
$meter_minus = [];
// each group has one-to-many points, each point has one-to-many meters
foreach($grouping->points as $point) {
foreach($point->meters as $meter) {
if($meter->Relation == '+') {
array_push($meter_plus, $meter);
} else {
array_push($meter_minus, $meter);
}
}
}
// Edit2: Point - Meter relation
public function meters()
{
return $this->belongsToMany('App\EnergyMeter', 'meteringpoint_energymeter_relation', 'point_id', 'meter_id')
->whereHas('users', function ($q) {
$q->where('UserID', Auth::id());
})
->where('Deleted', 0)
->select('*', 'meteringpoint_energymeter_relation.Relation')
->orderBy('EMNumber');
}
--
$plus = Data::selectRaw('sum(values) as data')
->where('PointOfTime', '>', $begin->format('U'))
->where('PointOfTime', '<=', $end->format('U'))
->whereIn('meter_id', collect($meter_plus)->lists('id'))
->first();
$minus = Data::selectRaw('sum(values) as data')
->where('PointOfTime', '>', $begin->format('U'))
->where('PointOfTime', '<=', $end->format('U'))
->whereIn('meter_id', collect($meter_minus)->lists('id'))
->first();
$data = $plus->data - $minus->data
This works fine but I would like to
improve the query
calculate the final sum in query

Answer 1

Use whereBetween for your PointOfTime range and sum instead of selectRaw. Also, if $meter_plus is already an array of just the id's, you don't need to do whatever it is you're doing with collect. You might also want to indicate a table to query.
$plus = Data::table('some_table')
->sum('values')
->whereBetween('PointOfTime',array($begin->format('U'), $end->format('U')))
->whereIn('meter_id', $meter_plus)
->sum('values')
->get();