Parsing nullable TJSONObject with Delphi - json

I'm using Delphi XE3. I have a JSON stream where an object can be null. That is, I can receive:
"user":null
or
"user":{"userName":"Pep","email":"pep#stackoverflow.com"}
I want to discriminate both cases, and I tried with this code:
var
jUserObject: TJSONObject;
jUserObject := TJSONObject(Get('user').JsonValue);
if (jUserObject.Null)
then begin
FUser := nil;
end else begin
FUser := TUser.Create;
with FUser, jUserObject do begin
FEmail := TJSONString(Get('email').JsonValue).Value;
FUserName := TJSONString(Get('userName').JsonValue).Value;
end;
end;
If I put a breakpoint right in line if (jUserObject.Null) then begin and I mouse over jUserObject.Null it says jUserObject.Null = True if "user":null and it says jUserObject.Null = False if "user":{"userName":"Pep","email":"pep#stackoverflow.com"}
However, if I step into that line with the debugger, jUserObject.Null calls the following XE3 library code:
function TJSONAncestor.IsNull: Boolean;
begin
Result := False;
end;
So I always get a False for my if sentence, even if "user":null.
I suppose I always have the workaround of catching the exception that is raised when "user":null and Get('email').JsonValue is executed in order to discriminate if the value is null or not, but that does not seem so elegant.
How is one supposed to detect if an JSON object has a null value in the JSON stream?

Get() returns a TJSONPair. When you have "user":null, the TJSONPair.JsonValue property will return a TJSONNull object, not a TJSONObject object. Your code is not accounting for that possibility. It assumes the JsonValue is always a TJSONObject and not validating the type-cast.
There are two ways to handle this.
TJSONPair has its own Null property that specifies whether its JsonValue is a null value or not:
var
JUser: TJSONPair;
jUserObject: TJSONObject;
jUser := Get('user');
if jUser.Null then begin
FUser := nil;
end else begin
// use the 'as' operator for type validation in
// case the value is something other than an object...
jUserObject := jUser.JsonValue as TJSONObject;
...
end;
Use the is operator to test the class type of the JsonValue before casting it:
var
JUser: TJSONPair;
jUserObject: TJSONObject;
jUser := Get('user');
if jUser.JsonValue is TJSONNull then begin
FUser := nil;
end
else if jUser.JsonValue is TJSONObject then begin
jUserObject := TJSONObject(jUser.JsonValue);
...
end else begin
// the value is something other than an object...
end;

You've made the common mistake of confusing JSON objects with Delphi objects. The TJSONObject class represents JSON objects only, which are never null because null is distinct from {...}. TJSONObject is not the ancestor for all JSON values, like your code assumes. TJSONValue is.
Don't type-cast your "user" value to TJSONObject until you know it's an object. Check the Null property first, then type-cast.

Related

How to create a function to convert a generic "TFPGObjectList" into a "TJsonArray"?

I'm new to fpc Lazarus and came from Delphi BackGround.
I need to create a method in order to convert Generic Object Lists into TJsonArray.
Delphi has it natively, but aparently FPC Lazarus doesn't.
Here is what I have:
generic class function TDAOJsonUtils.ObjectListToJsonArray<T>(aObjectList: T): TJsonArray;
var
I: Integer;
_JsonStr: TJSONStreamer;
_JsonObj: TJsonObject;
begin
result := TJsonArray.Create;
_JsonStr := TJSONStreamer.Create(nil);
try
for i := 0 to Pred(TFPGObjectList(aObjectList).Count) do
begin
_JsonObj := TJsonObject.Create;
end;
finally
FreeAndNil(_JsonStr);
end;
end;
It doesn't compile with and throw the following message at the "for loop" statement:
"generics without specialization cannot be used as a type for a variable"
Any tips?
Thank's in advance.

Memory leak When Returning TJSONVALUE from Function

I have a JSON array of objects that I iterate. From each element of the array I retrieve further json data via a function that returns a JSONValue. I then must add that returned jsonvalue to the specific array element.
It works perfectly except that Delphi is reporting a memory leak on shutdown and I just can't find it. I'm pretty new to JSON and I've spent all day on this. Can someone help by suggesting the right way to go about this. Simplified code below. Many Thanks.
function TForm1.Function1(ThisProductJSON: String): Integer;
Var
MultiObj : TJSONObject;
OtherValues : TJSONVALUE;
ThisObject : TJSONObject;
I : Integer;
jsArr : TJSONARRAY;
S:String;
Stockcode : String;
begin
MultiObj:=TJSONObject.Create(nil);
s:='[{"ThisElement":1,"Thiscode":12345,"ThisBarcode":"2345678901231","Price":1.00,"Measure":"EA","Description":"Some Description"},'+
'{"ThisElement":2,"Thiscode":21345,"ThisBarcode":"3124567890123","Price":2.00,"Measure":"EA","Description":"Some Description"},'+
'{"ThisElement":3,"Thiscode":31345,"ThisBarcode":"6123457890123","Price":3.00,"Measure":"EA","Description":"Some Description"},'+
'{"ThisElement":4,"Thiscode":41345,"ThisBarcode":"9123456780123","Price":4.00,"Measure":"EA","Description":"Some Description"},'+
'{"ThisElement":5,"Thiscode":51345,"ThisBarcode":"8234567901235","Price":5.00,"Measure":"EA","Description":"Some Description"}]';
ThisProductJSON:=S;
try
try
MultiObj.AddPair('ThisName','ThisValue');
MultiObj.AddPair('AnotherName','AnotherValue');
I:=0;
JSArr:=TJSONObject.ParseJSONValue(ThisProductJSON).AsType<TJSONARRAY>;
//Process all products in the array with a call to detailed Rest for each product
begin
for I := 0 to jsArr.count-1 do //iterate through the array
begin
Stockcode:= jsArr.Items[I].GetValue<string>('Thiscode');
ThisObject:=TJSONObject(jsArr[i]); // Make ThisObject Point to the jsArr[i] as an object so I can add the Other Values to this array element
OtherValues :=(GetOtherDetails(Stockcode)); // Call the below function to return the JSONVALUE containing addtional data
ThisObject.AddPair('OtherDetails',OtherValues); // Add all of the additional data in OtherValues JSONVALUE to this element of array via the object
end;
MultiObj.AddPair('WoWMultiProduct',JSARR); // This MultiObj hokds the consolidated data
end;
except
On E: Exception do
begin
//Errror handling here
end;
end;
finally
MultiObj.Free;
OtherValues.Free; // <<- I thought this would free the Result of the function but I think its leaking
JSARR.Free;
if assigned(ThisObject) then ThisObject.Free;
end;
end;
function TForm1.GetOtherDetails(Stockcode: String): TJSONVALUE;
Var
ThisResponseObject, MYRESULT : TJSONOBJECT;
vNIP, vCOO : TJSONVALUE;
begin
DetailedRESTRequest.execute; //<-- This REST Service Returns aditional JSON data
MyResult:=TJSONObject.Create;
if DetailedRESTResponse.StatusCode=200 then
begin
Try
Try
ThisResponseObject := TJSONObject.ParseJSONValue(DetailedRESTResponse.content)as TJSONObject; // Resd the entire JSON Response into TJSONObject
vCOO:=ThisResponseObject.Getvalue('COO'); // Get First JSON Value I need
vNIP:=ThisResponseObject.Getvalue('Nip'); // Get Next JSON Value I Need
MyResult.AddPair('NIPInfo',vNip); // Thiis is the only way I know how to Add the Values
MyResult.AddPair('COO',vCOO); // So that I can get them both together in the Result
Result:= TJSONObject.ParseJSONValue(MyResult.ToJSON)as TJSONValue; // Get back the JSONValue from the function
Except
On E:Exception do
begin
// Some Error Handling Here e.Classname+' ' +E.Message ;
end;
End;
Finally
If Assigned(ThisResponseObject) then ThisResponseObject.Free;
// NOTE IF I FREE MYRESULT OBJECT I GET ACCESS VIOLATION WHEN I TRY TO USE THE RESULT OF THE FUNCTION
End;
end;
end;
JSON objects are a tree-like data structure. When you request a value from a node, with getvalue (for example), it is actually giving you a reference to that node's object.
so, when you do the following in the "GetOtherDetails" function:
vCOO:=ThisResponseObject.Getvalue('COO');
MyResult.AddPair('COO',vCOO);
You make ThisResponseObject and MyResult share nodes (memory locations), so when you free one of them the other will try to free memory locations that no longer exist and generate the access violation
ThisResponseObject.free;
MyResult.Free; //access violation
Similarly, on "Function1" when doing:
ThisObject:=TJSONObject(jsArr[i]);
OtherValues :=(GetOtherDetails(Stockcode));
ThisObject.AddPair('OtherDetails',OtherValues);
You're making ThisObject contain OtherValues object... so when you try to free the two objects you're going to run into memory problems.

Parsing a JSON string that contains an array of an array of a string of another jsonstring in Delphi

So I'm talking to this webserver, and it's returning me a json entry like this:
{
"result": [
[],
["{\"success\": \"true\", \"Message\":\"User 1 has been deleted.\"}"]
]
}
{"result":[[],["{\"success\": \"true\", \"Message\":\"User 1 has been deleted.\"}"]]}
And I'm having trouble getting things out of it.
Looking at it, I made a jsonobject, pulled the value of result and made it an array, then pulled the second entry of the first array as another array, then took that jsonstring and turned it into another jsonarray, then took the values out.
but for some reason the first jsonarray claims to have two values, both of which are empty. I'm sure there are other errors in my approach past that point as well.
Can I get a hand ironing this thing out?
procedure DeleteUser;
var
aJSON, aResult : String;
aJsonResponse : TJsonObject;
aResultArrayA : TJsonArray;
aResultArrayB : TJsonArray;
aResultArrayC : TJsonArray;
aParsed : TJsonValue;
i : Integer;
Begin
aresult := '{"result":[[],["{\"success\": \"true\", \"Message\":\"User 1 has been deleted.\"}"]]}';
aJsonResponse := TJsonObject.ParseJSONValue(aResult) as TJsonObject;
if not (aJsonResponse is TJsonObject) then
raise Exception.Create('InvalidResponse');
aResultArrayA := aJsonResponse.getValue('result') as TJsonArray;
if aResultArrayA.Count <= 0 then //is 2
raise Exception.Create('InvalidResponse');
aJSON := aResultArrayA.Items[0].Value; // is ''
aJSON := aResultArrayA.Items[1].Value; // is ''
aResultArrayB := aResultArrayA.Items[0] as TJSONArray;
if aResultArrayB.Count <= 0 then // is 0
raise Exception.Create('InvalidResponse'); //raises here
aJSON := aResultArrayB.Items[0].Value;
aJSON := aResultArrayB.Items[1].Value;
aResultArrayC := TJSONObject.ParseJSONValue(aResultArrayB.Items[1].Value) as TJSONArray;
for aParsed in aResultArrayC do begin
aJson := aJson + aParsed.GetValue<string>('success') + ' ';
aJson := aJson + aParsed.GetValue<string>('message') + ' ';
end;
end;
Thanks everyone.
I really think that the best way to work with JSON is serialization and deserialization. Yes, there is some situations when it's better to use parsing, but look at this:
uses ...,Rest.Json;
TMyArray = ARRAY of ARRAY of string;
//class for deserialization outer JSON object
TMyParse = CLASS
private
FResult:TMyArray;
procedure SetResult(const Value: TMyArray);
public
property result:TMyArray read FResult write SetResult;
END;
//class for deserialization inner JSON object
TMyInnerParse = class
private
FSuccess:Boolean;
FMessage:string;
procedure SetMessage(const Value: String);
procedure SetSuccess(const Value: Boolean);
public
property success:Boolean read FSuccess write SetSuccess;
property message:String read FMessage write SetMessage;
end;
procedure DeleteUser;
var
OuterObj: TMyParse;
InnerObj: TMyInnerParse;
aResult: String;
i,j: Integer;
Begin
aResult := '{"result":[[],["{\"success\": \"true\", \"Message\":\"User 1 has been deleted.\"}"]]}';
try
OuterObj := TJson.JsonToObject<TMyParse>(aResult);
if Length(OuterObj.result) > 0 then
for i := 0 to Length(OuterObj.result) - 1 do
if length(OuterObj.result[i]) > 0 then
for j := 0 to Length(OuterObj.result[i]) - 1 do
begin
try
InnerObj := TJson.JsonToObject<TMyInnerParse>(OuterObj.result[i][j]);
//Do your work with result, that in InnerObj now
finally
if assigned(InnerObj) then
FreeAndNil(InnerObj);
end;
end;
finally
if assigned(OuterObj) then
FreeAndNil(OuterObj);
end;
end;
procedure TMyParse.SetResult(const Value: TMyArray);
begin
FResult := value;
end;
procedure TMyInnerParse.SetMessage(const Value: String);
begin
FMessage := value;
end;
procedure TMyInnerParse.SetSuccess(const Value: Boolean);
begin
FSuccess := value;
end;
For cycles in this code are awful, but it's the fastest way to show how you can solve your problem. And it's working.
I don't know what information can be in first empty array and this can be the reason for exceptions. Look at this code as working example, not full solution because lack of information.
It was tested on Delphi 10.1:
P.S. Using arrays are very old way of coding in this situation. But some time ago I met problem with serializing/deserializing TList and TObjectList. I'll try to use them and will return with result.
P.P.S. It tried to use TList, but my attempt fails. Maybe someone can describe how to implement it in a code above.
Found these functions in system.JSON and they just clicked for me.
/// <summary>Finds a JSON value and returns reference to it. </summary>
/// <remarks> Raises an exception when a JSON value could not be found. </remarks>
property P[const APath: string]: TJSONValue read GetValueP;{ default;}
property A[const AIndex: Integer]: TJSONValue read GetValueA;
var
aSuccess, aMessage : String
aJSON : TJSONObject;
begin
var aJSON:= TJSONObject.ParseJSONValue('{"result":[[],["{\"success\": \"true\", \"Message\":\"User has been deleted.\"}"]]}');
aSuccess := TJSONObject.ParseJSONValue(aJSON.P['result'].A[1].A[0].AsType<String>).P['success'].AsType<String>;
aMessage := TJSONObject.ParseJSONValue(aJSON.P['result'].A[1].A[0].AsType<String>).P['Message'].AsType<String>;
end;
Note that this needs exception handling, all of these functions will throw an exception if they fail to find the specified property.

delphi what is difference of [ and { in json array

I have a JSON string and need to parse it
JsonString :='{"uid":"1","full_name":"test","user_name":"test","mobile":"0999","send_sms":""' +',"recieve_sms":"","mob_app":"","password":"test","email":"","credit":"0.00","status":"agent","add_date":"2020-01-04 13:05:32","agent":"0","theme":""}';
LJsonArr := TJSONObject.ParseJSONValue(JsonString) as TJSONArray;
for LJsonValue in LJsonArr do
begin
for LItem in TJSONArray(LJsonValue) do begin
memo1.Lines.Add(Format('%s : %s',[TJSONPair(LItem).JsonString.Value, TJSONPair(LItem).JsonValue.Value]));
end;
end;
this not working but if I put JSON string in a [] the code work well.
what is the difference of [{}] with {} or [] and how can I process my string with just {}
Your code doesn't work because the JSON in question does not contain any arrays at all, so all of your typecasts to TJSONArray are wrong. The JSON represents a single object (a TJSONObject) containing name/value pairs of strings, nothing more.
By surrounding the JSON with [], you create an array that contains 1 element, an object. So your outer loop is satisfied, but your inner loop is still wrong since it would need to typecast LJsonValue to TJSONObject rather than TSONArray.
To process the original JSON correctly, try this instead:
JsonString :='{"uid":"1","full_name":"test","user_name":"test","mobile":"0999","send_sms":""' +',"recieve_sms":"","mob_app":"","password":"test","email":"","credit":"0.00","status":"agent","add_date":"2020-01-04 13:05:32","agent":"0","theme":""}';
LJsonValue := TJSONObject.ParseJSONValue(JsonString);
if LJsonValue <> nil then
try
LJsonObj := LJsonValue as TJSONObject;
for LJsonPair in LJsonObj do
begin
Memo1.Lines.Add(Format('%s : %s',[LJsonPair.JsonString.Value, LJsonPair.JsonValue.Value]));
end;
finally
LJsonValue.Free;
end;

Extracting/parsing data returned as JSON from PHP

I'm getting JSON data back from a PHP call using TIdHTTP. I'm expecting to use TJSONObject but can't work out how to use it for this purpose. And there are no examples in the XE3 help.
Sample JSON data
[{"fleet_id":"2","fleet":"EMB195"},{"fleet_id":"3","fleet":"EMB175"},{"fleet_id"‌:"1","fleet":"DHC84-400Q"}]
I'm sure this is simple, but how!
Thanks.
Use TJsonObject.ParseJsonValue to convert the input string into a JSON value:
var
val: TJsonValue;
s := '[{"fleet_id":"2","fleet":"EMB195"},{"fleet_id":"3","fleet":"EMB175"},{"fleet_id"‌:"1","fleet":"DHC84-400Q"}]';
val := TJsonObject.ParseJsonValue(s);
In this case, the JSON happens to represent an array, so you can type-cast it to that:
var
arr: TJsonArray;
arr := val as TJsonArray;
You can access the elements of the array with Get, and type-cast the results to TJsonObject.
var
i: Integer;
elem: TJsonObject;
for i := 0 to Pred(arr.Size) do begin
elem := arr.Get(i) as TJsonObject;
end;
To inspect the properties of the object, you can use the Get method, which returns a TJsonPair holding the name and value.