modifying this complicated mySql query - mysql

Question

I have 2 tables, adds, and adds_filters
Here are my tables:
CREATE TABLE IF NOT EXISTS `adds` (
`addid` int(11) NOT NULL AUTO_INCREMENT,
`memberid` int(11) NOT NULL,
`isnew` int(11) NOT NULL,
`catid` int(11) NOT NULL,
`manufacturerid` int(11) NOT NULL,
`modelid` varchar(255) DEFAULT NULL,
`colorid` int(11) DEFAULT NULL,
`geographicareaid` int(45) NOT NULL,
`addtypeid` varchar(45) NOT NULL,
`addcreatedon` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`addvalidfrom` date NOT NULL,
`addvaliduntil` date NOT NULL,
`addcreatedfromip` varchar(255) NOT NULL,
`yearofmanufacturing` varchar(255) DEFAULT NULL,
`monthofmanufacturing` int(11) DEFAULT NULL,
`hoursused` int(11) DEFAULT NULL,
`cc2` int(11) DEFAULT NULL,
`horsepowers` int(11) DEFAULT NULL,
`metalic` tinyint(4) DEFAULT NULL,
`isdamaged` tinyint(4) DEFAULT NULL,
`price` float DEFAULT NULL,
`hasvat` tinyint(4) NOT NULL,
`canbenegotiated` tinyint(4) DEFAULT NULL,
`addtitle` varchar(255) DEFAULT NULL,
`addtext` text NOT NULL,
`youtubevideo` varchar(255) DEFAULT NULL,
`visible` tinyint(4) DEFAULT NULL,
`ff1` varchar(255) DEFAULT NULL,
`ff2` varchar(255) DEFAULT NULL,
`ff3` varchar(255) DEFAULT NULL,
`ff4` varchar(255) DEFAULT NULL,
PRIMARY KEY (`addid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=43 ;
CREATE TABLE IF NOT EXISTS `adds_filters` (
`addfilterid` int(11) NOT NULL AUTO_INCREMENT,
`addid` int(11) NOT NULL,
`filterid` int(11) NOT NULL,
PRIMARY KEY (`addfilterid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=45 ;
I have the following sql query that works like a charm, but I need to modify it:
SELECT DISTINCT a.addid
, a.memberid
, a.isnew
, a.catid
, a.manufacturerid
, a.modelid
, a.colorid
, a.geographicareaid
, a.addtypeid
, a.addcreatedon
, a.addvalidfrom
, a.addvaliduntil
, a.addcreatedfromip
, a.yearofmanufacturing
, a.monthofmanufacturing
, a.hoursused
, a.cc2
, a.horsepowers
, a.metalic
, a.isdamaged
, a.price
, a.hasvat
, a.canbenegotiated
, a.addtitle
, a.addtext
, a.youtubevideo
, a.visible
, a.ff1
, a.ff2
, a.ff3
, a.ff4
FROM adds a
JOIN adds_filters f
ON f.addid = a.addid
WHERE a.catid = 1
AND a.manufacturerid = 1
AND f.filterid IN (67,158)
My problem here is the following: if I add one more filter, (example 162) query should returns no results, since there is no add that has all 3 filters. Current query returns 3 rows, which all have the 67 and 158. Anyone can tell me how can I get the desired result?
Regards, John

Answer 1

Here is SQLfiddle
You should understand, that you gonna need to dynamicaly add the subqueries to each checked filterid.
Here is the query (you also can play with filterids in the main SELECT:
SELECT t1.*, t2.filterid as filterid2
FROM
(
SELECT DISTINCT a.*,
f.`filterid`
FROM adds a
JOIN adds_filters f
ON a.`addid` = f.`addid`
WHERE a.`catid` = 1
AND a.`manufacturerid` = 1
AND f.`filterid` = 67
) t1
JOIN
(
SELECT DISTINCT a.`addid`,
f.`filterid`
FROM adds a
JOIN adds_filters f
ON a.`addid` = f.`addid`
WHERE a.`catid` = 1
AND a.`manufacturerid` = 1
AND f.`filterid` = 158
) t2
ON t1.addid = t2.addid
JOIN
(
SELECT DISTINCT a.`addid`,
f.`filterid`
FROM adds a
JOIN adds_filters f
ON a.`addid` = f.`addid`
WHERE a.`catid` = 1
AND a.`manufacturerid` = 1
AND f.`filterid` = 162
) t3
ON t1.addid = t3.addid;

Answer 2

You should be able to simply change your join to the adds_filters component
FROM adds a
JOIN ( select addid
from adds_filters
where filterid in ( 67, 158, 162 )
group by addid
having count(*) = 3 ) f
ON f.addid = a.addid
WHERE a.catid = 1
AND a.manufacturerid = 1
By changing to a prequery of only those AddIDs that have all 3 components (via group by and having), it will only return those valid AddIDs

Answer 3

I would tend to go with the suggestion by DRapp, but if there are issues knowing how many filters there are in advance when building the SQL then another possibility would me one inner join per filter.
SELECT DISTINCT a.addid
, a.memberid
, a.isnew
, a.catid
, a.manufacturerid
, a.modelid
, a.colorid
, a.geographicareaid
, a.addtypeid
, a.addcreatedon
, a.addvalidfrom
, a.addvaliduntil
, a.addcreatedfromip
, a.yearofmanufacturing
, a.monthofmanufacturing
, a.hoursused
, a.cc2
, a.horsepowers
, a.metalic
, a.isdamaged
, a.price
, a.hasvat
, a.canbenegotiated
, a.addtitle
, a.addtext
, a.youtubevideo
, a.visible
, a.ff1
, a.ff2
, a.ff3
, a.ff4
FROM adds a
INNER JOIN adds_filters f1
ON f1.addid = a.addid AND f1.filterid = 67
INNER JOIN adds_filters f2
ON f2.addid = a.addid AND f2.filterid = 158
INNER JOIN adds_filters f3
ON f3.addid = a.addid AND f3.filterid = 162
WHERE a.catid = 1
AND a.manufacturerid = 1