Having issues with MySQL Stored Procedure with multiple statements - mysql

Question

I am having a very bad time with a MySQL stored procedure, I can't created this procedure in the database (MySQL 5.5.27)
I a wondering why its rejecting my from variable declaration, multiple select and if else (Hopefully is some code error) I am pasting my code in!
DELIMITER $$
DROP PROCEDURE IF EXISTS EditEnterprise
$$
CREATE PROCEDURE EditEnterprise(
IN pEnterpriseId VARCHAR(32),
IN pEnterpriseName VARCHAR(64)
)
/* declare the new variables */
DECLARE nEnterpriseId VARCHAR(32);
DECLARE nEnterpriseName VARCHAR(64);
/* declare the old variables */
DECLARE oEnterpriseId VARCHAR(32);
DECLARE oEnterpriseName VARCHAR(64);
BEGIN
SET autocommit = 0;
/* get the old variables */
SELECT
Enterprise_ID = oEnterpriseId,
Enterprise_Name = oEnterpriseName
FROM
enterprise
WHERE
Enterprise_ID = pEnterpriseId;
/* set the variables with the new inputs */
IF pEnterpriseName = NULL
SET nEnterpriseName = oEnterpriseName
ELSE IF pEnterpriseName = ''
SET oEnterpriseName = NULL
ELSE
SET nEnterpriseName = pEnterpriseName
UPDATE enterprise
SET
Enterprise_Name = nEnterpriseName
WHERE Enterprise_ID = pEnterpriseId;
COMMIT;
END $$
DELIMITER ;

Answer 1

There are some mistakes in the SP and it should be something like this
DELIMITER $$
DROP PROCEDURE IF EXISTS EditEnterprise
$$
CREATE PROCEDURE EditEnterprise(
IN pEnterpriseId VARCHAR(32),
IN pEnterpriseName VARCHAR(64)
)
BEGIN
/* declare the new variables */
DECLARE nEnterpriseId VARCHAR(32);
DECLARE nEnterpriseName VARCHAR(64);
/* declare the old variables */
DECLARE oEnterpriseId VARCHAR(32);
DECLARE oEnterpriseName VARCHAR(64);
SET autocommit = 0;
/* get the old variables */
SELECT
#oEnterpriseID := Enterprise_ID,
#oEnterpriseName := Enterprise_Name
FROM
enterprise
WHERE
Enterprise_ID = pEnterpriseId;
/* set the variables with the new inputs */
IF pEnterpriseName = NULL THEN
SET #nEnterpriseName = #oEnterpriseName;
ELSEIF pEnterpriseName = '' THEN
SET #oEnterpriseName = NULL;
ELSE
SET #nEnterpriseName = pEnterpriseName;
END IF;
UPDATE enterprise
SET
Enterprise_Name = nEnterpriseName,
Enterprise_Established_Date = nEnterpriseCreateDate,
Enterprise_Description = nEnterpriseDetails,
Enterprise_Type = nEnterpriseType,
Enterprise_Status = nEnterpriseStatus
WHERE Enterprise_ID = pEnterpriseId;
COMMIT;
END $$
DELIMITER ;
Some errors to point out
Its ELSEIF instead if ELSE IF for multiple conditions
After declaring a variable "DECLARE myvar VARCHAR(32)", we need to use := to assign values to it if we are not using the SET command.

Answer 2

In Mysql (which differs from Oracle), DECLARE goes after BEGIN
Your code should be:
DELIMITER $$
DROP PROCEDURE IF EXISTS EditEnterprise$$
CREATE PROCEDURE EditEnterprise(
IN pEnterpriseId VARCHAR(32),
IN pEnterpriseName VARCHAR(64)
)
BEGIN
/* declare the new variables */
DECLARE nEnterpriseId VARCHAR(32);
DECLARE nEnterpriseName VARCHAR(64);
/* declare the old variables */
DECLARE oEnterpriseId VARCHAR(32);
DECLARE oEnterpriseName VARCHAR(64);
SET autocommit = 0;
/* get the old variables */
SELECT
Enterprise_ID := oEnterpriseId,
Enterprise_Name := oEnterpriseName
FROM
enterprise
WHERE
Enterprise_ID = pEnterpriseId;
/* set the variables with the new inputs */
IF pEnterpriseName IS NULL THEN
SET nEnterpriseName = oEnterpriseName;
ELSEIF pEnterpriseName = '' THEN
SET oEnterpriseName = NULL;
ELSE
SET nEnterpriseName = pEnterpriseName;
END IF;
UPDATE enterprise SET
Enterprise_Name = nEnterpriseName
WHERE Enterprise_ID = pEnterpriseId;
COMMIT;
END$$
DELIMITER ;
I also added the missing ;, THEN and END IF keywords.
Also, take note that you might have a typo at this line:
SET oEnterpriseName = NULL;
You probably meant:
SET nEnterpriseName = NULL;
Now I think you should reconsider your stored procedure. Indeed, all this could be done in a single SQL query. Do you really need a stored procedure for this? Except if you have a restrictive grants policy it might just be superfluous.